isEmpty for linked list

bustle · Aug 11, 2015 · 3dceea4 · 3dceea4
1 parent 462d9a7
commit 3dceea4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/js/models/markup-section.js b/src/js/models/markup-section.js
@@ -105,7 +105,7 @@ export default class Section extends LinkedItem {
         this.markers.remove(m);
       }
     });
-    if (this.markers.empty()) {
+    if (this.markers.isEmpty) {
       this.markers.append(this.builder.createBlankMarker());
     }
   }

diff --git a/src/js/utils/linked-list.js b/src/js/utils/linked-list.js
@@ -9,7 +9,7 @@ export default class LinkedList {
       this.freeItem = freeItem;
     }
   }
-  empty() {
+  get isEmpty() {
     return this.length === 0;
   }
   prepend(item) {

diff --git a/tests/unit/utils/linked-list-test.js b/tests/unit/utils/linked-list-test.js
@@ -10,6 +10,7 @@ test('initial state', (assert) => {
   assert.equal(list.head, null, 'head is null');
   assert.equal(list.tail, null ,'tail is null');
   assert.equal(list.length, 0, 'length is one');
+  assert.equal(list.isEmpty, true, 'isEmpty is true');
 });
 
 ['append', 'prepend', 'insertBefore', 'insertAfter'].forEach(method => {
@@ -18,6 +19,7 @@ test('initial state', (assert) => {
     let item = new LinkedItem();
     list[method](item);
     assert.equal(list.length, 1, 'length is one');
+    assert.equal(list.isEmpty, false, 'isEmpty is false');
     assert.equal(list.head, item, 'head is item');
     assert.equal(list.tail, item, 'tail is item');
     assert.equal(item.next, null, 'item next is null');
@@ -132,6 +134,7 @@ test(`#remove an only item`, (assert) => {
   list.append(item);
   list.remove(item);
   assert.equal(list.length, 0, 'length is zero');
+  assert.equal(list.isEmpty, true, 'isEmpty is true');
   assert.equal(list.head, null, 'head is null');
   assert.equal(list.tail, null, 'tail is null');
   assert.equal(item.prev, null, 'item prev is null');