Atoms should not be editable

bustle · Feb 2, 2016 · 573453a · 573453a
1 parent 5b887b1
commit 573453a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/js/renderers/editor-dom.js b/src/js/renderers/editor-dom.js
@@ -113,6 +113,7 @@ function renderCard() {
 
 function renderAtom(element, previousRenderNode) {
   let atomElement = document.createElement('span');
+  atomElement.contentEditable = false;
   addClassName(atomElement, '-mobiledoc-kit__atom');
 
   if (previousRenderNode) {

diff --git a/tests/unit/renderers/editor-dom-test.js b/tests/unit/renderers/editor-dom-test.js
@@ -210,7 +210,7 @@ test('renders a post with atom', (assert) => {
       }
     }
   ]);
-  assert.equal(renderTree.rootElement.innerHTML, `<p><span class="-mobiledoc-kit__atom">@bob</span></p>`);
+  assert.equal(renderTree.rootElement.innerHTML, `<p><span contenteditable="false" class="-mobiledoc-kit__atom">@bob</span></p>`);
 });
 
 test('renders a post with mixed markups and atoms', (assert) => {
@@ -238,7 +238,7 @@ test('renders a post with mixed markups and atoms', (assert) => {
     }
   ]);
 
-  assert.equal(renderTree.rootElement.innerHTML, `<p><b>bold<i>italic <span class="-mobiledoc-kit__atom">@bob</span></i> bold</b>text.</p>`);
+  assert.equal(renderTree.rootElement.innerHTML, `<p><b>bold<i>italic <span contenteditable="false" class="-mobiledoc-kit__atom">@bob</span></i> bold</b>text.</p>`);
 });
 
 test('renders a card section', (assert) => {