bug fix: embed intent hiding

bustle · Jul 18, 2014 · 822d40a · 822d40a
1 parent 6d69d9c
commit 822d40a
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 7 deletions.
diff --git a/dist/content-kit-editor.js b/dist/content-kit-editor.js
@@ -3,7 +3,7 @@
  * @version  0.1.0
  * @author   Garth Poitras <garth22@gmail.com> (http://garthpoitras.com/)
  * @license  MIT
- * Last modified: Jul 17, 2014
+ * Last modified: Jul 18, 2014
  */
 
 (function(exports, document) {
@@ -218,8 +218,8 @@ function tagsInSelection(selection) {
 }
 
 function selectionIsInElement(selection, element) {
-  var node = selection.focusNode,
-      parentNode = node.parentNode;
+  var node = selection.anchorNode,
+      parentNode = node && node.parentNode;
   while(parentNode) {
     if (parentNode === element) {
       return true;
@@ -1040,6 +1040,10 @@ var EmbedIntent = (function() {
     embedIntent.isActive = false;
 
     function embedIntentHandler(e) {
+      if (!selectionIsInElement(window.getSelection(), rootElement)) {
+        embedIntent.hide();
+        return;
+      }
       var currentNode = getCurrentSelectionRootNode();
       var currentNodeHTML = currentNode.innerHTML;
       if (currentNodeHTML === '' || currentNodeHTML === '<br>') {
@@ -1051,7 +1055,13 @@ var EmbedIntent = (function() {
     }
 
     rootElement.addEventListener('keyup', embedIntentHandler);
-    document.addEventListener('mouseup', embedIntentHandler);
+    document.addEventListener('mouseup', function(e) { setTimeout(function() { embedIntentHandler(e); }); });
+
+    document.addEventListener('keyup', function(e) {
+      if (e.keyCode === Keycodes.ESC) {
+        embedIntent.deactivate();
+      }
+    });
 
     window.addEventListener('resize', function() {
       if(embedIntent.isShowing) {

diff --git a/src/js/embed-intent.js b/src/js/embed-intent.js
@@ -23,6 +23,10 @@ var EmbedIntent = (function() {
     embedIntent.isActive = false;
 
     function embedIntentHandler(e) {
+      if (!selectionIsInElement(window.getSelection(), rootElement)) {
+        embedIntent.hide();
+        return;
+      }
       var currentNode = getCurrentSelectionRootNode();
       var currentNodeHTML = currentNode.innerHTML;
       if (currentNodeHTML === '' || currentNodeHTML === '<br>') {
@@ -34,7 +38,13 @@ var EmbedIntent = (function() {
     }
 
     rootElement.addEventListener('keyup', embedIntentHandler);
-    document.addEventListener('mouseup', embedIntentHandler);
+    document.addEventListener('mouseup', function(e) { setTimeout(function() { embedIntentHandler(e); }); });
+
+    document.addEventListener('keyup', function(e) {
+      if (e.keyCode === Keycodes.ESC) {
+        embedIntent.deactivate();
+      }
+    });
 
     window.addEventListener('resize', function() {
       if(embedIntent.isShowing) {

diff --git a/src/js/utils/selection-utils.js b/src/js/utils/selection-utils.js
@@ -51,8 +51,8 @@ function tagsInSelection(selection) {
 }
 
 function selectionIsInElement(selection, element) {
-  var node = selection.focusNode,
-      parentNode = node.parentNode;
+  var node = selection.anchorNode,
+      parentNode = node && node.parentNode;
   while(parentNode) {
     if (parentNode === element) {
       return true;