Optimize the compiler loop

bustle · Dec 14, 2015 · eeca363 · eeca363
1 parent 26d3d78
commit eeca363
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/src/js/utils/compiler.js b/src/js/utils/compiler.js
@@ -1,3 +1,5 @@
+import { forEach } from './array-utils';
+
 export function visit(visitor, node, opcodes) {
   const method = node.type;
   if (!visitor[method]) {
@@ -9,10 +11,15 @@ export function visit(visitor, node, opcodes) {
 export function compile(compiler, opcodes) {
   for (var i=0, l=opcodes.length; i<l; i++) {
     let [method, ...params] = opcodes[i];
-    if (params.length) {
-      compiler[method].apply(compiler, params);
-    } else {
+    let length = params.length;
+    if (length === 0) {
       compiler[method].call(compiler);
+    } else if (length === 1) {
+      compiler[method].call(compiler, params[0]);
+    } else if (length === 2) {
+      compiler[method].call(compiler, params[0], params[1]);
+    } else {
+      compiler[method].apply(compiler, params);
     }
   }
 }
@@ -21,7 +28,7 @@ export function visitArray(visitor, nodes, opcodes) {
   if (!nodes || nodes.length === 0) {
     return;
   }
-  nodes.forEach(node => {
+  forEach(nodes, node => {
     visit(visitor, node, opcodes);
   });
 }