Remove extraneous arguments in toolbar/view logic

src/js/editor/editor.js

@@ -262,7 +262,7 @@ class Editor {
 
     this.element = element;
 
-    this.applyClassName(EDITOR_ELEMENT_CLASS_NAME);
+    addClassName(this.element, EDITOR_ELEMENT_CLASS_NAME);
     this.applyPlaceholder();
 
     element.spellcheck = this.spellcheck;
@@ -388,10 +388,6 @@ class Editor {
     return new Cursor(this);
   }
 
-  applyClassName(className) {
-    addClassName(this.element, className);
-  }
-
   applyPlaceholder() {
     const placeholder = this.placeholder;
     const existingPlaceholder = getData(this.element, 'placeholder');

src/js/models/markup-section.js

@@ -37,6 +37,8 @@ const MarkupSection = class MarkupSection extends Markerable {
   splitAtMarker(marker, offset=0) {
     let [beforeSection, afterSection] = [
       this.builder.createMarkupSection(this.tagName, []),
+      // FIXME we probably want to make it so that we create a new default markup
+      // section instead of copying the same tagname to the section below
       this.builder.createMarkupSection(this.tagName, [])
     ];
 

src/js/utils/dom-utils.js

@@ -116,6 +116,11 @@ function addClassName(element, className) {
   element.classList.add(className);
 }
 
+function removeClassName(element, className) {
+  // FIXME-IE IE10+
+  element.classList.remove(className);
+}
+
 function normalizeTagName(tagName) {
   return tagName.toLowerCase();
 }
@@ -136,6 +141,7 @@ export {
   walkDOM,
   walkTextNodes,
   addClassName,
+  removeClassName,
   normalizeTagName,
   isTextNode,
   parseHTML

src/js/views/reversible-toolbar-button.js

@@ -1,8 +1,10 @@
 import mixin from '../utils/mixin';
 import EventListenerMixin from '../utils/event-listener';
+import { addClassName, removeClassName } from '../utils/dom-utils';
 
 const ELEMENT_TYPE = 'button';
 const BUTTON_CLASS_NAME = 'ck-toolbar-btn';
+const ACTIVE_CLASS_NAME = 'active';
 
 class ReversibleToolbarButton {
   constructor(command, editor) {
@@ -53,11 +55,8 @@ class ReversibleToolbarButton {
 
   set active(val) {
     this._active = val;
-    if (this._active) {
-      this.element.className = BUTTON_CLASS_NAME + ' active';
-    } else {
-      this.element.className = BUTTON_CLASS_NAME;
-    }
+    let method = this._active ? addClassName : removeClassName;
+    method(this.element, ACTIVE_CLASS_NAME);
   }
 
   get active() {

src/js/views/text-format-toolbar.js

@@ -13,14 +13,13 @@ export default class TextFormatToolbar extends Toolbar {
 
   handleResize() {
     if (this.isShowing) {
-      const activePromptRange = this.activePrompt && this.activePrompt.range;
-      this.positionToContent(activePromptRange ? activePromptRange : window.getSelection().getRangeAt(0));
+      this.positionToContent();
     }
   }
 
   handleSelection() {
     this.show();
-    this.updateForSelection(window.getSelection());
+    this.updateForSelection();
   }
 
   handleSelectionEnded() {

src/js/views/toolbar.js

@@ -67,14 +67,16 @@ class Toolbar extends View {
     this.updateForSelection();
   }
 
-  updateForSelection(selection=window.getSelection()) {
+  updateForSelection() {
     if (!this.isShowing) { return; }
-    if (!selection.isCollapsed) {
-      this.positionToContent(selection.getRangeAt(0));
+    const selection = window.getSelection(),
+          range     = selection && selection.getRangeAt(0);
+    if (!range.collapsed) {
+      this.positionToContent(range);
     }
   }
 
-  positionToContent(content) {
+  positionToContent(content=window.getSelection().getRangeAt(0)) {
     var directions = ToolbarDirection;
     var positioningMethod, position, sideEdgeOffset;
     switch(this.direction) {