Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a link and typing to replace only applies link markup to first char #630

Closed
kevinansfield opened this issue Jun 20, 2018 · 1 comment

Comments

@kevinansfield
Copy link
Collaborator

If you select an entire link (or any part of a link that includes the last character) then start typing to replace the text, the link markup is only applied to the first character:

link-replacement

@kevinansfield
Copy link
Collaborator Author

Looking into this the reason why it happens is clear and it's no different than many other editors...

  • Medium: same behaviour
  • Dropbox paper: same behaviour
  • Quill: same behaviour
  • Google docs: removes link entirely
  • Pages: removes link entirely

Both Google Docs and Pages have extra UI that allows for replacing the link text which is currently possible with mobiledoc-kit if implementors want that experience.

Closing because I think the current behaviour is probably the right approach for core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant