Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with PHP 8 I got error "require int, null given" #26

Closed
DenisDangerous opened this issue Oct 16, 2020 · 1 comment
Closed

with PHP 8 I got error "require int, null given" #26

DenisDangerous opened this issue Oct 16, 2020 · 1 comment
Assignees
@butschster
Labels
bug Something isn't working

Comments

@DenisDangerous
Copy link

src/MetaTags/Entities/Title.php
with PHP 8 I got error "require int, null given"

fix it with adding "|null"
line 39: public function __construct(string $title = null, int|null $maxLength = self::DEFAULT_LENGTH)
@butschster butschster self-assigned this Oct 20, 2020
@butschster butschster added the bug Something isn't working label Oct 20, 2020
butschster added a commit that referenced this issue Oct 20, 2020
@butschster
Fixed problem with nullable method args
5ffb58a 
- Fixed tests with exceptions
- Added tests for php 7.4, 8.0

issue #26
@butschster
Copy link
Owner

Hi!
I couldn't use __construct(string $title = null, int|null $maxLength = self::DEFAULT_LENGTH) this style, because this code is incompatible with 7.x version.
I've made some fixes and you can try new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@butschster butschster

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@butschster @DenisDangerous