Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Save de-bouncing #182

Open
perry-mitchell opened this issue Oct 20, 2017 · 0 comments
Open

[Feature] Save de-bouncing #182

perry-mitchell opened this issue Oct 20, 2017 · 0 comments

Comments

@perry-mitchell
Copy link
Member

Saving needs to be de-bounced so that multiple saves don't happen over each-other. The two main areas that need this attention are:

  • Workspaces
  • Archive Manager

The de-bounce for each needs to be double-edged. Regular debouncing occurs like so:

______________________________________________s

Here the debounce may be using a delay of say 500ms, saving on the trailing side.

Our debounce should be saved both times:

s_____________________________________________s

And instead of a delay, it would be the save period (time the promise takes to save and complete). The save should occur immediately, and if another save request comes, it should be queued.. marking the need for saving as dirty. When an existing save request completes, if the flag is dirty, a new save should be undertaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant