Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New occurences method #70

Closed
6 tasks
emilos opened this issue Jul 4, 2019 · 4 comments
Closed
6 tasks

New occurences method #70

emilos opened this issue Jul 4, 2019 · 4 comments

Comments

@emilos
Copy link
Contributor

emilos commented Jul 4, 2019

Acceptance criteria

  • occurences method in collection.js
  • works for arrays (e.g. occurences(["foo", "foo", "bar"], "foo") returns 2)
  • works for strings (e.g. occurences("foo foo bar", "foo") returns 2)
  • tests
  • docs
  • examples
@emilos emilos changed the title occurences New occurences method Nov 9, 2019
@inikonorov
Copy link
Contributor

how this method must work with strings? can I consider that repeated substrings always separated by space?

@emilos
Copy link
Contributor Author

emilos commented Nov 10, 2019

@inikonorov that should be good enough for start, there's always room for improvement in the future if needed

@inikonorov
Copy link
Contributor

done!
#85

@emilos
Copy link
Contributor Author

emilos commented Nov 11, 2019

@inikonorov thanks for all of the help! I've released it as v1.1.16

@emilos emilos closed this as completed Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants