Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split functions into directories and separate files #92

Closed
4 tasks
emilos opened this issue Nov 14, 2019 · 7 comments
Closed
4 tasks

Split functions into directories and separate files #92

emilos opened this issue Nov 14, 2019 · 7 comments

Comments

@emilos
Copy link
Contributor

emilos commented Nov 14, 2019

Story

As a developer, I'd like to import a function per file so that the bundler I use has less work to do.

Acceptance criteria

  • create directories per type (array, string, collection etc.)
  • create a file per function (e.g. deepclone, capitalize etc. are in separate files)
  • create an index file (array/index.js) that requires all deps from given dir and exports them
  • tests should work as they do now
@inikonorov
Copy link
Contributor

Hi! Is it okay?
#100

If I did what you need, so I'll update this PR by adding another functions :)

@emilos
Copy link
Contributor Author

emilos commented Nov 22, 2019

@inikonorov that's correct!

@inikonorov
Copy link
Contributor

in 'string' methods there is 'index' method - i can't create file with this name, because the main file of folder already has the same name. what should I do?

@emilos
Copy link
Contributor Author

emilos commented Nov 22, 2019

good question. Maybe put it inside the index.js file that imports other files as a function at the top

@inikonorov
Copy link
Contributor

okay

@inikonorov
Copy link
Contributor

done!
#100

@emilos
Copy link
Contributor Author

emilos commented Nov 23, 2019

@inikonorov thanks so much for your time!

@emilos emilos closed this as completed Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants