Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to change MediaInfoModule.wasm location #41

Closed
nelson777 opened this issue Jul 24, 2020 · 2 comments
Closed

Allow user to change MediaInfoModule.wasm location #41

nelson777 opened this issue Jul 24, 2020 · 2 comments

Comments

@nelson777
Copy link

Hello,

In this closed issue I had some difficulties using this library in Angular. So I asked for help in Stackoverflow in this question, and it worked perfectly.

Then I created a working example for Angular users, so others could have an easier path than mine. I also created a pull request with the example. It's here

I would like to say that I made this effort because I thought, given it's great usefulness, this project was worth the effort. Thanks for your work in it.

Finally I also want to give you an idea to create an option that allows the user to change MediaInfoModule.wasm location from root to some other arbitrary location. For most projects, root is not ideal for any library, not library part.

Hope it's useful for you and other users.

@buzz buzz changed the title Angular example pull request and suggestion Allow user to change MediaInfoModule.wasm location Jul 24, 2020
@buzz
Copy link
Owner

buzz commented Jul 24, 2020

Please see the mentioned comments section of the PR regarding the pull request.

I will use the issue to discuss your suggestion to change the WASM location.

This is actually already possible using the available tooling. See here: https://emscripten.org/docs/api_reference/module.html#Module.locateFile

This would indeed involve editing the build script by hand, adding the --pre-js option to emcc. If you can think of a general solution that allows users of the library to customize the path in a convenient way, I'll be happy to accept a PR.

@nelson777
Copy link
Author

Right now I don't have time to work in my suggestion. But maybe I can try in the follwing weeks. If I have any success in doing that I'll let you know.

I also created a new pull request with the changes you asked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants