Use CommonCrypto instead of CryptoSwift #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Nice work. |
|
This is awesome, thanks! Validates in the News app, so I'll merge this in here and then we should see about getting this branch into master. |
dmauro
added a commit
that referenced
this pull request
May 27, 2015
Use CommonCrypto instead of CryptoSwift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based this on the following SO answers. It uses a dummy framework to import CommonCrypto so that the end user of Mattress doesn't have to add the module map to their own project.
http://stackoverflow.com/questions/24123518/how-to-use-cc-md5-method-in-swift-language
http://stackoverflow.com/questions/25248598/importing-commoncrypto-in-a-swift-framework