Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConcurrentSetBlockingQueue.offer() should return true when element already exists #6

Open
jruaux opened this issue Dec 4, 2020 · 0 comments

Comments

@jruaux
Copy link

jruaux commented Dec 4, 2020

BlockingQueue documentation for offer() method says it should return true upon success and false if no space is currently available.
I think this block in ConcurrentSetBlockingQueue should return true instead of false:

if (set.contains(e)) {
    return false;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant