Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/refactor config #8

Merged
merged 2 commits into from Oct 24, 2022
Merged

Feat/refactor config #8

merged 2 commits into from Oct 24, 2022

Conversation

aburd
Copy link
Contributor

@aburd aburd commented Oct 24, 2022

Description

Refactors config.rs and settings.rs with impl blocks

What

  • Move some logic from build_project.rs to Config and Settings structs
  • Add comments where necessary
  • Add idiomatic impl blocks for the above structs with methods like new when necessary

Why

  • To make it easier to use the Config and Settings structs
  • To make it easier to read modules that use the above structs

@aburd
feat: move struct logic
4f82b52 
Some of the logic dealing with the mechanics of the Config and settings structs were moved to the modules where the structs are defined to reduce some of the noise in the other modules. In addition, some struct properties were made private and access to that data is made available through functions in order to hide some complexity from the consumer.
@aburd
fix: consumers due to struct changes
2767c8f 
As the Config and Settings structs were updated, the consumers needed to
be updated.
@aburd aburd marked this pull request as draft October 24, 2022 10:41
bvanseg
bvanseg approved these changes Oct 24, 2022
View reviewed changes
Copy link
Owner

@bvanseg bvanseg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aburd aburd marked this pull request as ready for review October 24, 2022 11:00
@bvanseg bvanseg merged commit 8140717 into bvanseg:master Oct 24, 2022
@bvanseg bvanseg added this to the 1.0.0 (Vanilla Release) milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvanseg bvanseg bvanseg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0 (Vanilla Release)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aburd @bvanseg