Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uneven focus ring #69

Closed
gaearon opened this issue Apr 4, 2019 · 3 comments
Closed

Uneven focus ring #69

gaearon opened this issue Apr 4, 2019 · 3 comments
Assignees
Labels
😎 enhancement New feature or request

Comments

@gaearon
Copy link
Collaborator

gaearon commented Apr 4, 2019

This was introduced by #53.

You can only see the unevenness when the tree is small enough to fit on a single screen:

Screen Shot 2019-04-04 at 23 06 42

I think we can just hide that focus ring altogether, and instead either show a custom one in the right area (e.g. via focus events), or not show it altogether (somewhat worse).

An ideal version would be to show it in the right place and only if you navigated into the area by tabbing.

@gaearon gaearon added the 😭 bug Something isn't working label Apr 4, 2019
@gaearon gaearon self-assigned this Apr 4, 2019
@bvaughn bvaughn added 😎 enhancement New feature or request and removed 😭 bug Something isn't working labels Apr 4, 2019
@bvaughn
Copy link
Owner

bvaughn commented Apr 5, 2019

This has to do with overflow/clipping. Before I added custom :focus styles to e.g. the owners list, those buttons had the same problem. I'd be happy to pick this up if you'd like a hand. (Not going to touch it for the moment though, since you've self assigned it.)

@gaearon
Copy link
Collaborator Author

gaearon commented Apr 5, 2019

If you don’t mind doing it that would be great! I’m going to focus on the suspense fragment thing.

@gaearon gaearon removed their assignment Apr 5, 2019
@bvaughn bvaughn self-assigned this Apr 5, 2019
@bvaughn
Copy link
Owner

bvaughn commented Apr 5, 2019

Fixed via d1a5346. Also addressed a couple of other minor keyboard navigation UX issues I noticed while testing.

@bvaughn bvaughn closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😎 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants