Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorBoundaryFallbackComponent is unnecessary #3

Closed
blling opened this issue Oct 15, 2017 · 2 comments
Closed

ErrorBoundaryFallbackComponent is unnecessary #3

blling opened this issue Oct 15, 2017 · 2 comments

Comments

@blling
Copy link

blling commented Oct 15, 2017

Users will not use the ErrorBoundaryFallbackComponent most of the time, so we can remove it from core lib and put it in a separeted showcase ?

@bvaughn
Copy link
Owner

bvaughn commented Oct 20, 2017

That component can be dead-code eliminated from any production app that uses this library without using it, so I don't see the harm in leaving it? It's also tiny. 😄

@bvaughn
Copy link
Owner

bvaughn commented Oct 20, 2017

I think I'm going to leave it in for my own convenience (one less project to maintain and sync) and b'c I don't think it's much of a problem, given my previous comment ^

Thanks for raising this issue though!

@bvaughn bvaughn closed this as completed Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants