useErrorHandler: use unknown instead of Error #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make the return type explicit * treat null and undefined as no error
kentcdodds
reviewed
May 5, 2021
| function useErrorHandler(givenError?: unknown): (error: unknown) => void { | ||
| const [error, setError] = React.useState<unknown>(null) | ||
| if (givenError != null) throw givenError | ||
| if (error != null) throw error |
There was a problem hiding this comment.
Those might give you a lint issue. If it does, you can just disable the rule for the project/file.
|
@kentcdodds for the validating step here is the issue i mentioned already present on master, see my other pull to fix that issue |
|
🎉 This PR is included in version 3.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the useErrorHandler hook, i've changed the type of the error from
Errortounknown.What:
Not all thrown exceptions are of type
Error, see #83 for a discussion concerning this changeWhy:
NA
How:
I've made the changes as agreed upon and also corrected the documentation
Checklist:
I've noticed that current master has a linting issue on the fallback in the render method, i'll take a look at it