Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TS): help typescript to find his way for the ErrorBoundaryProps #90

Merged
merged 1 commit into from May 5, 2021

Conversation

tommarien
Copy link
Contributor

…nion

This fixes a lot of issue concerning the union and ensures typescript which is which

What: Assist typescript in union type of ErrorBoundaryProps and cleanup related leftovers

Why: A linting error was present on master

How: NA

Checklist:

  • Documentation NA
  • Tests
  • [X ] Ready to be merged

Snapshots needed updating because of the stacktrace changes

…nion

This fixes a lot of issue concerning the union and ensures typescript which is which
Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

@kentcdodds kentcdodds merged commit fb0b859 into bvaughn:master May 5, 2021
@github-actions
Copy link

github-actions bot commented May 5, 2021

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tommarien tommarien deleted the fix-linting-boundary branch May 10, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants