Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel Runtime and corejs conflicts with babel 7+ versions #1373

Closed
gaetan-puleo opened this issue May 10, 2019 · 9 comments
Closed

Babel Runtime and corejs conflicts with babel 7+ versions #1373

gaetan-puleo opened this issue May 10, 2019 · 9 comments

Comments

@gaetan-puleo
Copy link

gaetan-puleo commented May 10, 2019

Hello I have @babel/runtime installed as a dev dependency and in react-virtualized I can see that babel-runtime is used as a normal dependency.

I have a conflict between my version and yours.

@gunn4r
Copy link

gunn4r commented Jun 5, 2019

Curious why you closed this @gaetan-puleo. I am trying to upgrade my repo to latest babel 7.4.x using corejs 3 and it seems react-virtualized version of babel-runtime is causing issues for me. Did you find a solution that worked well?

@gaetan-puleo gaetan-puleo reopened this Jun 5, 2019
@gaetan-puleo
Copy link
Author

@gunn4r I reopen it.

I fixed this issue by installing core-js as peer dependencies in my package.json

  "peerDependencies": {
    "core-js": "2.6.5"
  }

@csvan
Copy link

csvan commented Jun 7, 2019

We are having issues with this as well when it comes to upgrading to corejs 3 - it inevitably breaks react-virtualized.

Babel 6 has been obsolete for a long time now. It would benefit this project and community at large if an upgrade was made.

@csvan
Copy link

csvan commented Jun 7, 2019

@gunn4r I reopen it.

I fixed this issue by installing core-js as peer dependencies in my package.json

  "peerDependencies": {
    "core-js": "2.6.5"
  }

Sadly that is not a solution. Core-js 2 is deprecated and tightly bound to the old way of doing things in Babel 6. People using Babel 7.4+ and core-js 3 will not be able to integrate react-virtualized due to it.

@gaetan-puleo
Copy link
Author

gaetan-puleo commented Jun 7, 2019

@gunn4r I reopen it.
I fixed this issue by installing core-js as peer dependencies in my package.json

  "peerDependencies": {
    "core-js": "2.6.5"
  }

Sadly that is not a solution. Core-js 2 is deprecated and tightly bound to the old way of doing things in Babel 6. People using Babel 7.4+ and core-js 3 will not be able to integrate react-virtualized due to it.

Yes I know, I think the contributors need to update the babel version and corejs.

Maybe I can help if needed.

I will try to do a PR this week end if I have the time to do it.

@gaetan-puleo gaetan-puleo changed the title Babel Runtime Babel Runtime and corejs conflicts with babel 7 versions Jun 7, 2019
@gaetan-puleo gaetan-puleo changed the title Babel Runtime and corejs conflicts with babel 7 versions Babel Runtime and corejs conflicts with babel 7+ versions Jun 7, 2019
@jonasantonelli
Copy link

I had the same problem with the latest version of core-js@3.1.4
But it worked when I downgraded to version core-js@2.6.5

@jseminck
Copy link

Is there any way to have a build of react-virtualized without core-js included?

@betalb
Copy link

betalb commented Feb 27, 2020

The common approach seems to be to ship esnext version of code. In case of react-virtualized original source can be used with flow annotations removed (if any)

End consumer will have to do final transpilation and use any version of babel runtime it needs

@bvaughn
Copy link
Owner

bvaughn commented Apr 9, 2023

Version 9.22.4 has been published with peer dependencies updated to include React 17 and 18. (No other changes from 9.22.3)

https://github.com/bvaughn/react-virtualized/releases/tag/v9.22.4

@bvaughn bvaughn closed this as completed Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants