Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 17 #1616

Closed
cocreature opened this issue Dec 3, 2020 · 11 comments · Fixed by #1625
Closed

Support React 17 #1616

cocreature opened this issue Dec 3, 2020 · 11 comments · Fixed by #1625

Comments

@cocreature
Copy link

Currently, react-virtualized has a peer dependency on react and react-dom that constraints it to React 16. From my experiments, it already seems to work with React 17 so this might be as simple as just bumping the bounds.

@stheine
Copy link

stheine commented Feb 4, 2021

This is getting more important when using React 17 and upgrading to npm 7.x, as there is a breaking change about the peer dependency resolution, resulting in

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0-alpha" from react-virtualized@9.22.3
npm ERR! node_modules/react-virtualized
npm ERR!   react-virtualized@"9.22.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

the workaround is using --legacy-peer-deps, but it would be great if react-virtualized would officially support React 17.

@joachimklug
Copy link

As time flies I was wondering if there is any reason to hold back this PR? Or any way to contribute to get this done.

@tbrd
Copy link

tbrd commented Mar 12, 2021

Would be lovely to get this merged

@thexpand
Copy link

Why is this still not closed and the PR merged?

@reinisg
Copy link

reinisg commented Apr 20, 2021

Maybe this command helps for now > npm install react-virtualized --legacy-peer-deps

@PeterNitscheMGM
Copy link

@bvaughn
Hi Brian,
the company I'm working for is really interested in the React 17 support.
Is there anything we can do to achieve this goal?

We are looking forward collaborating with you!

Best regards
Peter

@SeymurPasha
Copy link

Maybe this command helps for now > npm install react-virtualized --legacy-peer-deps

This worked for me. Thanks

@rigobertoalag
Copy link

Maybe this command helps for now > npm install react-virtualized --legacy-peer-deps

Work for me too!

@juzerzarif
Copy link

Can we get a version released with this change in it?

@Mikeks81
Copy link

Is there anyway i can help to get the most recent updates released so that it include react17 as a peer dep?

@davidkiss96
Copy link

Guys if someone has the desire, contact him please:
bvaughn commented 6 days ago
I haven't used this package in years. I don't have the mental bandwidth or the desire to maintain it. If someone else (preferably someone who actively uses it) wants to step up and publish this release (and deal with any potential breaks it causes, since there are several changes committed since the last release) then please email me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.