Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more than 1000 items in the examples #85

Closed
phpnode opened this issue Feb 5, 2016 · 2 comments
Closed

Show more than 1000 items in the examples #85

phpnode opened this issue Feb 5, 2016 · 2 comments

Comments

@phpnode
Copy link

phpnode commented Feb 5, 2016

Hi, thanks for this great library. In the examples it would be really useful to see how it performs when there are many more than 1000 rows, e.g. 1,000,000.

@bvaughn
Copy link
Owner

bvaughn commented Feb 5, 2016

Fair enough. I mainly avoided this because I didn't want to spend a lot of time generating fake data and give the impression that the slowness that results was due to react-virtualized. Maybe I'll just remove the upper bounds on the number of rows/cols and just loop through my sample list.

@bvaughn bvaughn closed this as completed in 0df29c1 Feb 5, 2016
@bvaughn
Copy link
Owner

bvaughn commented Feb 5, 2016

Check out the updated demo. Defaults to 1000 still but you can crank it up as high as you want (until you run into max-browser-size dimensions as mentioned on #73)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants