Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windowscroller #30

Closed
jfrolich opened this Issue Jul 27, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@jfrolich
Copy link

jfrolich commented Jul 27, 2018

Thanks for your work on this, looks really impressive 馃帀

I am interested if you are open to add windowscroller functionality in this library or if that is out of scope for this library perhaps because of performance reasons.

In our app we make use of react-virtualized at this moment, but it's always great to switch to a more performant alternative. If I can find time, I am interested to help out with the implementation of the windowscroller functionality.

@bvaughn

This comment has been minimized.

Copy link
Owner

bvaughn commented Jul 27, 2018

WindowScroller was one of those painful to maintain components. I see the usefulness of it, but I'm not sure I'm interested in committing to maintain another one. I would prefer instead, if possible, for an external component to be built (and published separately) that implements this functionality on top of react-window.

I might be willing to make a couple of changes to react-window to support such a component, if it existed, depending on how complex they would be.

Maybe a good initial start would be for someone (you?) to submit a PR that adds it to this library directly鈥 so we could see how complicated it might be to publish separately.

@PascalSenn

This comment has been minimized.

Copy link

PascalSenn commented Oct 11, 2018

If you really need a window scroller, you can just use the one of react-virtalized.

WindowScroller
https://codesandbox.io/s/vy620pkzzy

WindowScroller with dynamic content
https://codesandbox.io/s/xvl23p7okp

@bvaughn

This comment has been minimized.

Copy link
Owner

bvaughn commented Oct 11, 2018

I think I'm going to close this issue for now since I don't plan on taking any action on it鈥攁nd the long term plan (in my mind at least) was a separate module anyway. I'd still be happy to take a look at a proposal though!

@bvaughn bvaughn closed this Oct 11, 2018

@carlosagsmendes

This comment has been minimized.

Copy link

carlosagsmendes commented Jan 11, 2019

Hu @PascalSenn , are you using the WindowScroller from react-virtualized with success? Thanks in advance

@carlosagsmendes

This comment has been minimized.

Copy link

carlosagsmendes commented Jan 17, 2019

Hi again @PascalSenn , I'm trying your approach with a grid but it is not working for me. Can you help?

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.