-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
position sticky headers #55
Comments
Ah it was |
I honestly don't know. I stepped back through the history of react-window and react-virtualized looking for a commit when I added this, to see if I could jog my memory and I couldn't find one. I think it has been around since the beginning. At least for Chrome, Safari, and Firefox it does not look to be necessary. Would you be willing to test this a bit on IE and mobile? If it seems okay, I would accept a PR to remove that style. |
Yup! Definitely. It sounds safe to remove since the |
Thanks! I look forward to the PR 😄 |
FYI here's an idea I had that you might find interesting https://codesandbox.io/s/0mk3qwpl4l |
Nice!! We ended up grouping our lists so we didn't run into any issues with sticky positioning, but this is a great little snippet to have on hand. Thanks for sharing! 🙏 |
@bvaughn This is awesome! Could you add this to recipes? |
It does not solve sticky column problem though. |
Not trying to solve every problem with this example. Just illustrating how the current API could be used to approach this. Should work the same for columns as rows. |
I've created this project: You can read more about the project here: I also have async effort to maybe bring this change in some way into react-window #98. |
Curious if there is a way to hook into react-window to allow use of position sticky? Similar to https://github.com/marchaos/react-virtualized-sticky-tree. As a quick test I tried rendering a larger row with sticky headers, but it doesn't seem to be working. Seems like we would need some hooks or a way to tell the header to stay in view for so many pixels 🤔. Still working on things and will report back with whatever I find, just wanted to see if this has been thought about or explored yet.
The text was updated successfully, but these errors were encountered: