Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line ending problem #61

Closed
EricE opened this issue Mar 25, 2022 · 3 comments · Fixed by #63
Closed

Line ending problem #61

EricE opened this issue Mar 25, 2022 · 3 comments · Fixed by #63
Labels
bug Something isn't working

Comments

@EricE
Copy link

EricE commented Mar 25, 2022

Just tried ssort on a Windows 10 machine. I copied your example and saved it with CRLF line endings then ran ssort. It rewrote the line endings without removing the old ones (added a CR for each CRLF), here are some screenshots from Notepad++:

Initial file:
image

After:
image
@bwhmather bwhmather added the bug Something isn't working label Mar 25, 2022
@bwhmather
Copy link
Owner

Ouch. That's an interesting one. Suspect the bug was introduced when we fixed support for different encodings. Hopefully the same path can be used to fix it. Will have an experiment, but may need to ask for your help to test on windows.

@bwhmather bwhmather mentioned this issue Mar 25, 2022
Merged
@bwhmather
Copy link
Owner

Have the start of an approach in #63. Will pick it up again at some point tomorrow and try to get a release out over the weekend.

@bwhmather
Copy link
Owner

Fix released as part of 0.11.5. @EricE - Please let me know if you still have issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for detecting and preserving different newline types bwhmather/ssort
2 participants
@EricE @bwhmather