Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub URI retrieval uses Kernel#open which is deprecated #19

Closed
kriation opened this issue Dec 5, 2020 · 1 comment
Closed

GitHub URI retrieval uses Kernel#open which is deprecated #19

kriation opened this issue Dec 5, 2020 · 1 comment

Comments

@kriation
Copy link
Contributor

kriation commented Dec 5, 2020 •
edited
Loading

Discovered in testing today that the plugin is using Kernel#open instead of
URI#open when retrieving contents from GitHub. Ruby threw the following
deprecation notice:

Jekyll Feed: Generating feed for posts
/home/akale/repository/code/codecommit/kriation/blog/vendor/ruby/2.7.0/gems/jekyll_github_sample-0.3.2/lib/jekyll_github_sample/code_tag.rb:19:
warning: calling URI.open via Kernel#open is deprecated, call URI.open directly
or use URI#open
@kriation kriation mentioned this issue Dec 5, 2020
Merged
@kriation kriation closed this as completed Dec 7, 2020
@kriation
Copy link
Contributor Author

kriation commented Dec 7, 2020

PR merged.

@kriation kriation changed the title GitHub URI retrieval uses Kerel#open which is deprecated GitHub URI retrieval uses Kernel#open which is deprecated Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kriation