Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive information exposure via logs. #11

Open
amcgregor opened this issue Jan 14, 2019 · 1 comment
Open

Sensitive information exposure via logs. #11

amcgregor opened this issue Jan 14, 2019 · 1 comment

Comments

@amcgregor
Copy link

Howdy! One of the little details I've run into is that there are logging statements within the codebase that log sensitive information, e.g. connection URI (without password redaction) or straight-up logging of the credentials, e.g. https://github.com/bwmcadams/mongodb_beaker/blob/master/mongodb_beaker/__init__.py#L256 :

log.info("Attempting to authenticate %s/%s " % (username, password))

Please avoid logging passwords! Thank you.

@amcgregor
Copy link
Author

Additionally, all of the URI parsing and processing included within this project can be essentially eliminated through utilization of the uri library. To correct this, and to correct the seeming inability to specify self-expiry dates (valid_until for use with TTL indexes) on sessions, we have vendored this library into our application and patched.

More than two years to correct a security issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant