-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for changing Outlets to Lights #59
Comments
Hey @PeteCooney, while I can see where you're coming from I think doing so would add a layer of unnecessary complexity to the setup process, make breaking changes to the user's current config, and could introduce bugs due to how Homebridge sets up a devices characteristics. When a device in initialized within Homebridge it is assigned characteristics based on the service type provided by the plugin, an outlet from the Meross plugin in this situation. If the user is allowed to edit this value they would be able to initialize let's say a MSS210 as a MSG100 (Garage door opener). The MSS210 would then be sending incompatible requests to the Meross server such as a setting and receiving a GarageDoorState which could result in errors. If you would like to experiment with this you can edit line 101 in I feel as though the goal of a plugin is to provide a simplistic interface between the device and Homebridge and let the Home.app / HomeKit handle the rest. Let me know your thoughts! |
Hi @dylanfrankcom, thanks for the detailed reply, much appreciated. Regarding some of the risks you highlight:
I may take you up on the idea of tinkering with the code and, if I find an elegant solution, I'll be sure to submit a pull request for review. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Thank you for your contributions. |
See #151 |
I have a number of MSS210 plug adapters that I use to control lights (table lamps etc) around the house.
While it's possible to change the type of device within the Home app, it would be great to be able to override the default service type when creating the accessory within Homebridge.
The text was updated successfully, but these errors were encountered: