missing go.sum entry error

[benmathews]

$ go version
go version go1.16.2 linux/amd64
$ mkdir testbingo
$ cd testbingo/
$ go get -u github.com/bwplotka/bingo
$ bingo get -l github.com/bwplotka/bingo
Bingo not used before here, creating directory for pinned modules for you at .bingo
Error: get command failed: get: bingo.mod: getting github.com/bwplotka/bingo: install: go: github.com/bwplotka/bingo@v0.3.1: missing go.sum entry; to add it:
	go mod download github.com/bwplotka/bingo
: exit 1
$ go mod download github.com/bwplotka/bingo
go mod download: module github.com/bwplotka/bingo: not a known dependency

[mvenable]

This issue appears to be because the go list command requires the go.sum file to exist in go 1.16. To validate this I created a local hack that runs go download (with the modfile variable) to populate the go.sum prior to list being run. After this change all of the tests passed and it appeared to function correctly again.

--- a/get.go
+++ b/get.go
@@ -580,6 +580,10 @@ func install(runnable runner.Runnable, name string, link bool, pkg *bingo.Packag
                return errors.Wrap(err, pkg.String())
        }
 
+       if err := runnable.Download(runner.NoUpdatePolicy); err != nil {
+               return err
+       }
+
        // Check if path is pointing to non-buildable package. Fail it is non-buildable. Hacky!
        if listOutput, err := runnable.List(runner.NoUpdatePolicy, "-f={{.Name}}", pkg.Path()); err != nil {
                return err

--- a/pkg/runner/runner.go
+++ b/pkg/runner/runner.go
@@ -80,6 +80,7 @@ var cmdsSupportingModFileArg = map[string]struct{}{
        "install": {},
        "list":    {},
        "build":   {},
+       "download": {},
 }
 
 func (r *Runner) execGo(ctx context.Context, output io.Writer, cd string, modFile string, args ...string) error {
@@ -121,6 +122,7 @@ func (r *Runner) exec(ctx context.Context, output io.Writer, cd string, command
 }
 
 type Runnable interface {
+       Download(update GetUpdatePolicy, args ...string) error
        List(update GetUpdatePolicy, args ...string) (string, error)
        GetD(update GetUpdatePolicy, packages ...string) (string, error)
        Build(pkg, out string) error
@@ -176,6 +178,19 @@ func (r *runnable) List(update GetUpdatePolicy, args ...string) (string, error)
        return strings.Trim(out.String(), "\n"), nil
 }
 
+// List runs `go list` against separate go modules files if any.
+func (r *runnable) Download(update GetUpdatePolicy, args ...string) error {
+       a := []string{"mod", "download"}
+       if update != NoUpdatePolicy {
+               a = append(a, string(update))
+       }
+       out := &bytes.Buffer{}
+       if err := r.r.execGo(r.ctx, out, r.dir, r.modFile, append(a, args...)...); err != nil {
+               return errors.Wrap(err, out.String())
+       }
+       return nil
+}
+
 // GoEnv runs `go env` with given args.
 func (r *runnable) GoEnv(args ...string) (string, error) {
        out := &bytes.Buffer{}

[bwplotka]

Hi we fixed this in recent release, please check 🤗

https://github.com/bwplotka/bingo/releases/tag/v0.4.0

Your suggested changes would work, but there are some edge cases that had to be fixed too. Thanks!

[benmathews]

I'm getting the same result as before with 0.4.0.

$ mkdir testbingo
$ cd testbingo/
$ go get -u github.com/bwplotka/bingo
go: downloading github.com/bwplotka/bingo v0.4.0
$ bingo get -l github.com/bwplotka/bingo
Bingo not used before here, creating directory for pinned modules for you at .bingo
Error: get command failed: get: bingo.mod: getting github.com/bwplotka/bingo: install: go: github.com/bwplotka/bingo@v0.4.0: missing go.sum entry; to add it:
	go mod download github.com/bwplotka/bingo
: exit 1
$ go mod download github.com/bwplotka/bingo
go mod download: module github.com/bwplotka/bingo: not a known dependency

[benmathews]

However, if I cp from the installed location to where bingo is expecting it to be then it works.

$ mkdir testbingo
$ cd testbingo/
$ go get -u github.com/bwplotka/bingo
$ bingo get -l github.com/bwplotka/bingo
bash: /home/ben/.gvm/pkgsets/go1.16.2/global/bin/bingo: No such file or directory
$ cp ~/go/bin/bingo /home/ben/.gvm/pkgsets/go1.16.2/global/bin/bingo
$ bingo get -l github.com/bwplotka/bingo
Bingo not used before here, creating directory for pinned modules for you at .bingo

[bwplotka]

Thanks, will add your info to new issue #88 to track it (:

[bwplotka]

It should be now resolved, including the documentation update to add -mod=mod option to Go build. Thanks!