Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthru Hue device does not use name set in ha-bridge #254

Closed
TheOriginalAndrobot opened this issue Nov 20, 2016 · 6 comments
Closed

Passthru Hue device does not use name set in ha-bridge #254

TheOriginalAndrobot opened this issue Nov 20, 2016 · 6 comments
Assignees
Milestone

Comments

@TheOriginalAndrobot
Copy link
Contributor

Currently, the name set in the ha-bridge item config of a passthru Hue device is ignored and instead the original device name from the Hue Bridge is advertised to clients of ha-bridge. It would be great if the device name was overridden in the pass-through response to use the configured name instead.

@bwssytems bwssytems self-assigned this Nov 20, 2016
@bwssytems
Copy link
Owner

I can update the response to use the ha-bridge name. Makes sense as it is proxied.

@bwssytems
Copy link
Owner

Now looking at my code, I am very confused on what name is not passed? All the responses use ID and I do set the ID of the bridge.

@TheOriginalAndrobot
Copy link
Contributor Author

Say I have the following setup:

I have a real Hue light named "Real Lamp", as set in the Hue App and stored in the Hue Bridge.

In ha-bridge, I set it up as a passthru device. In the edit device page, I set the 'Name' field to "Fake Lamp". The device shows up in the ha-bridge 'Bridge Devices' list as "Fake Lamp".

The clients of ha-bridge see a device called "Real Lamp" instead of "Fake Lamp". I would have expected the name set in ha-bridge to override the name reported by the Hue Bridge.

@bwssytems
Copy link
Owner

Ahh, got it. It is in the pass through 'get' lights call.

@bwssytems bwssytems added this to the V4.0.0 milestone Dec 27, 2016
@nldroid
Copy link

nldroid commented Jan 17, 2017

Just a question:

I noticed this behavior too. My Google Home reports the Hue name and not the ha-bridge name.

Do users need to re-add the devices after changing the name? Or does everything internally work with ID's? If users need to re-add, maybe it's an idea to add a line in the release notes..

@bwssytems
Copy link
Owner

This will be changed in the new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants