This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
fix: vm creation window collapses #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1291
💛 - Coveralls |
wowshakhov
suggested changes
Oct 26, 2018
| @@ -280,11 +280,11 @@ export const getComputeOfferingForVmEditing = createSelector( | |||
| const cpuNumber = | |||
| account && account.cpuavailable === 'Unlimited' | |||
| ? account.cpuavailable | |||
| : Number(account.cpuavailable) + cpuNumberUsed; | |||
| : Number(account.cpuavailable) + cpuNumberUsed || '0'; | |||
There was a problem hiding this comment.
- Why '0'? Can we use 0 in code and then convert to whatever representation we need in the end?
- I suggest that we do this calculation in a separate function, because it is rather complex and is the same for cpu and memory
wowshakhov
approved these changes
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.