This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
fix(account-sidebar): fix account long name are above the other label… #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in account sidebar
Pull Request Test Coverage Report for Build 1517
💛 - Coveralls |
|
Add ellipsis: |
wowshakhov
suggested changes
Dec 27, 2018
| @@ -12,26 +10,22 @@ | |||
| > | |||
| <mat-expansion-panel-header> | |||
| <mat-panel-title> | |||
| {{ user.firstname }} {{ user.lastname }} | |||
| <div class="mat-tab-tooltip" [matTooltip]="user.firstname + user.lastname"> | |||
There was a problem hiding this comment.
"+" concatenates strings without a space. It looks bad:
| </mat-panel-title> | ||
| <mat-panel-description> | ||
| </mat-panel-description> | ||
| <mat-panel-description> </mat-panel-description> |
There was a problem hiding this comment.
Remove mat-panel-description if it's not useful.
| @@ -12,26 +10,22 @@ | |||
| > | |||
| <mat-expansion-panel-header> | |||
| <mat-panel-title> | |||
| {{ user.firstname }} {{ user.lastname }} | |||
| <div class="mat-tab-tooltip" [matTooltip]="user.firstname + user.lastname"> | |||
There was a problem hiding this comment.
Why do we need the mat-tab-tooltip class in the first place?
wowshakhov
suggested changes
Dec 27, 2018
| @@ -0,0 +1,11 @@ | |||
| .mat-expansion-panel-header { | |||
| max-width: 100%; | |||
There was a problem hiding this comment.
seems like it doesn't do anything
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| max-width: 95%; |
There was a problem hiding this comment.
is max-width: 95%; necessary?
| max-width: 100%; | ||
| } | ||
|
|
||
| .entity-card-title { |
There was a problem hiding this comment.
you can replace entity-card-title with truncate from app.scss
src/app/account/account-sidebar/account-users/account-users.component.html
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s in account sidebar