This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
feat(vm-snapshot): manage maximum VM snapshots amount in config.json #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wowshakhov
suggested changes
Jan 14, 2019
config-guide.md
Outdated
| @@ -121,6 +122,17 @@ For example, | |||
| ] | |||
| ``` | |||
|
|
|||
| ### VM Snapshots Limit | |||
|
|
|||
| Allows you to set a maximum amount of vm snapshots. | |||
There was a problem hiding this comment.
the maximum number of VM snapshots
| this.store.pipe(select(vmSnapshotSelectors.getVmSnapshotsAmountForSelectedVm)), | ||
| ), | ||
| exhaustMap(([action, vmSnapLimit, snapshotsAmount]) => { | ||
| if (vmSnapLimit && vmSnapLimit <= snapshotsAmount) { |
There was a problem hiding this comment.
rename snapshotsAmount to snapshotNumber
| @@ -107,6 +107,9 @@ | |||
| "ISO": { | |||
| "VMS_IN_USE": "Unable to delete the ISO as it's used by the following VMs:<br>{{ vms }}" | |||
| }, | |||
| "VM_SNAPSHOT": { | |||
| "LIMIT_EXCEEDED": "The maximum amount of VM snapshots is exceeded. Please check your configurations" | |||
There was a problem hiding this comment.
Why is "configurations" written in plural? (both English and Russian)
There was a problem hiding this comment.
It is from requirements. I will ask PM.
wowshakhov
approved these changes
Jan 15, 2019
# Conflicts: # src/app/core/config/validation-schemes/index.ts # src/app/root-store/server-data/vm-snapshots/vm-snapshots.effects.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.