This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
feat(vm-creation): Improve shared SGs - Support assigning of many gro… #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ups during VM creation
zolotyx
suggested changes
Oct 31, 2017
| <ng-container *ngIf="securityGroups?.length"> | ||
| {{ securityGroupsLine }} | ||
| </ng-container> | ||
| <ng-container *ngIf="!securityGroups?.length"> |
| @Input() public securityGroups: Array<SecurityGroup>; | ||
|
|
||
| public get securityGroupsLine(): string { | ||
| if (this.securityGroups) { |
| } | ||
| } | ||
|
|
||
| public checkSelectedSG(securityGroupId: string) { |
| @@ -67,6 +69,7 @@ export class VmCreationSecurityGroupComponent implements OnInit { | |||
| } | |||
|
|
|||
| public onSave(): void { | |||
| console.log('SAVED DATA', this.savedData); | |||
| @@ -60,7 +60,7 @@ export class VmDeploymentService { | |||
|
|
|||
| public deploy(state: VmCreationState): VmDeployObservables { | |||
| const deployStatusObservable = new Subject<VmDeploymentMessage>(); | |||
|
|
|||
| console.log('11111 DEPLOY STATE', state); | |||
| @@ -108,7 +108,8 @@ export class VmDeploymentService { | |||
| return this.getSecurityGroupCreationObservable(deployObservable, state) | |||
| }) | |||
| .map(securityGroup => { | |||
| state.securityGroupData.securityGroup = securityGroup; | |||
| // state.securityGroupData.securityGroups.push(securityGroup); // @todo | |||
| console.log('DEPLOYMENT STATE', state); | |||
There was a problem hiding this comment.
remove console.log and comment
| @@ -19,7 +19,8 @@ <h4 matLine> | |||
| {{ sg.description }} | |||
| </p> | |||
| <span> | |||
| <mat-radio-button [checked]="sg?.id === securityGroup?.id"></mat-radio-button> | |||
| <mat-checkbox | |||
| [checked]="checkSelectedSG(sg?.id)"></mat-checkbox> | |||
There was a problem hiding this comment.
Sometimes it happens (item is selected but checkbox is not checked)
HeyRoach
force-pushed
the
591-improve-shared-sg-in-vm-creation
branch
from
b8ddaa6
to
1e2559d
Compare
…ups during VM creation - fixes
HeyRoach
force-pushed
the
591-improve-shared-sg-in-vm-creation
branch
from
1e2559d
to
316ead9
Compare
zolotyx
suggested changes
Oct 31, 2017
…ups during VM creation - fixes 2
HeyRoach
force-pushed
the
591-improve-shared-sg-in-vm-creation
branch
from
7e0ed66
to
d6db905
Compare
zolotyx
approved these changes
Nov 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ups during VM creation