This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
fix(sg-actions): Remove delete button for system firewall templates #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolotyx
reviewed
Dec 11, 2017
| @@ -17,7 +17,7 @@ const SecurityGroupShowRulesAction = { | |||
| name: 'SECURITY_GROUP_PAGE.ACTION.RULES', | |||
| command: SecurityGroupActionType.View, | |||
| icon: 'visibility', | |||
| canActivate: (securityGroup: SecurityGroup) => true | |||
| canActivate: (securityGroup: SecurityGroup) => securityGroup.type !== SecurityGroupType.PredefinedTemplate | |||
There was a problem hiding this comment.
I believe that the changes should be done 7 lines above. 😕
There was a problem hiding this comment.
should we use canActivate or isHidden?
zolotyx
suggested changes
Dec 11, 2017
| @@ -17,7 +17,7 @@ const SecurityGroupShowRulesAction = { | |||
| name: 'SECURITY_GROUP_PAGE.ACTION.RULES', | |||
| command: SecurityGroupActionType.View, | |||
| icon: 'visibility', | |||
| canActivate: (securityGroup: SecurityGroup) => true | |||
| canActivate: (securityGroup: SecurityGroup) => securityGroup.type !== SecurityGroupType.PredefinedTemplate | |||
There was a problem hiding this comment.
should we use canActivate or isHidden?
HeyRoach
force-pushed
the
747-sg-delete-button
branch
from
b1bf2ed
to
536114c
Compare
HeyRoach
changed the title
zolotyx
approved these changes
Dec 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.