Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support arduino:samd Core >= 1.8.10 #45

Closed
bxparks opened this issue Jan 25, 2021 · 1 comment
Closed

support arduino:samd Core >= 1.8.10 #45

bxparks opened this issue Jan 25, 2021 · 1 comment

Comments

@bxparks
Copy link
Owner

bxparks commented Jan 25, 2021

The arduino::samd core converted to using a new Arduino API for versions >= 1.8.10. (The SparkFun::samd core is fine). I don't have time to work on this right now, so I will explicitly blacklist these boards in AceTime.h so that the user gets a useful error message, instead of pages of compiler errors.

(This issue is identical to bxparks/AUnit#66).
@bxparks bxparks changed the title support arduino::samd Core >= 1.8.10 support arduino:samd Core >= 1.8.10 Jan 25, 2021
@bxparks bxparks mentioned this issue Feb 9, 2021
Closed
@stonehippo stonehippo mentioned this issue Feb 22, 2021
Closed
@per1234 per1234 mentioned this issue Feb 23, 2021
Merged
facchinm added a commit to facchinm/AceTime that referenced this issue Mar 29, 2021
@facchinm
Readd compatibility with samd and megaavr architectures
9ed0ad2 
Needs bxparks/AceCommon#14, arduino/ArduinoCore-API#144 and arduino/ArduinoCore-samd#612

Fixes bxparks#45 and arduino/ArduinoCore-samd#606
@facchinm facchinm mentioned this issue Mar 29, 2021
Closed
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
src/LocalDateTime.{h,cpp}: Move implementation of forDateString(const…
c621132 
… __FlashStringHelper*) into .cpp file, to avoid including <Arduino.h> in the header file (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
src/OffsetDateTime.{h,cpp}: Move implementation of forDateString(cons…
b86520c 
…t __FlashStringHelper*) into .cpp file, to avoid including <Arduino.h> in the header file (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
src/ZonedDateTime.cpp: Add '#include <Arduino.h>' to get 'Print' func…
28055aa 
…tions (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
tests/SystemClockTest: Add explicit casting to (int32_t) to fix stric…
c116ca4 
…ter compiler errors on arduino:samd>=1.8.11 (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
src/AceTime.h: Update arduino:samd blacklist to reenable once a new v…
64145b2 
…ersion 1.8.12 is released (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
src/LocalDateTime.{h,cpp}: Move implementation of forDateString(const…
552f5b6 
… __FlashStringHelper*) into .cpp file, to avoid including <Arduino.h> in the header file (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
src/OffsetDateTime.{h,cpp}: Move implementation of forDateString(cons…
ad81548 
…t __FlashStringHelper*) into .cpp file, to avoid including <Arduino.h> in the header file (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
src/ZonedDateTime.cpp: Add '#include <Arduino.h>' to get 'Print' func…
8783805 
…tions (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
tests/SystemClockTest: Add explicit casting to (int32_t) to fix stric…
601f8e6 
…ter compiler errors on arduino:samd>=1.8.11 (see #45)
bxparks added a commit that referenced this issue Apr 2, 2021
@bxparks
src/AceTime.h: Update arduino:samd blacklist to reenable once a new v…
f56d29f 
…ersion 1.8.12 is released (see #45)
@bxparks
Copy link
Owner Author

bxparks commented Nov 4, 2021

AceTime will not support ArduinoCore-api in the foreseeable future. So it will not support Arduinocore-samd >=1.8.10. Closing.

@bxparks bxparks closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Readd compatibility with samd and megaavr architectures facchinm/AceTime
1 participant
@bxparks