Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropQuals is a bit overzealous #3

Closed
dmwit opened this issue Mar 4, 2018 · 2 comments
Closed

dropQuals is a bit overzealous #3

dmwit opened this issue Mar 4, 2018 · 2 comments

Comments

@dmwit
Copy link
Contributor

dmwit commented Mar 4, 2018

This interaction is a bit confusing:

Math.Combinatorics.Species> structureType partition
": Set Set"

From a brief code dive, it looks like dropQuals, which is supposed to turn something like Math.Combinatorics.Species.Set into just Set, is having a field day with the :.: type constructor.

Reported first on StackOverflow.

@byorgey
Copy link
Owner

byorgey commented Mar 9, 2018

Oh dear. Thanks for the report! dropQuals really shouldn't be a String -> String function. But I don't know if there's a better way to get the information than tyConName which returns a String instead of something more structured.

@byorgey
Copy link
Owner

byorgey commented Apr 10, 2018

It turns out that tyConNames aren't qualified anymore (there's tyConModule if you want to know that part), so dropQuals is completely unnecessary. I took the opportunity to also fix up the display of infix type operators so they are actually displayed infix:

> structureType partition
"Set :.: Set"

Uploaded to Hackage as species-0.4.0.1. Note it still doesn't work with GHC-8.4, that's on my list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants