-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ navigation bars #137
✨ navigation bars #137
Conversation
I've added navigation bars to Trends, Search and Ingredients pages. As for me, it looks miles better now. Hope you like it too! Also I've changed a bit Ingredients page - now it looks a bit cleaner, as for me
Are we going to continue working on this project? |
ingredientsItem.image = UIImage(systemName: "list.bullet.rectangle") | ||
ingredientsC.tabBarItem = ingredientsItem | ||
ingredientsC.title = "Ingredients" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NSLocalizedString?
searchItem.image = UIImage(systemName: "magnifyingglass") | ||
searchC.tabBarItem = searchItem | ||
searchC.title = "Search" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И тут
trendItem.image = UIImage(systemName: "chart.line.uptrend.xyaxis") | ||
trendC.tabBarItem = trendItem | ||
trendC.title = "Trends" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И утт
override func viewDidAppear(_ animated: Bool) { | ||
super.viewDidAppear(animated) | ||
if !suggestionScrollView.isHidden { | ||
searchBar.becomeFirstResponder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Надо бы проверить на canBecomeFirstResponder
I've added navigation bars to Trends, Search and Ingredients pages. As for me, it looks miles better now. Hope you like it too!
Also I've changed a bit Ingredients page - now it looks a bit cleaner, as for me