Add compositional layout with two sections #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daria25D
force-pushed
the
dev/daria25D/horizontal-scroll
branch
from
3eeaf53
to
ef9c639
Compare
daria25D
requested review from
kiberkotleta92,
aldonin,
chizberg and
bypolinafox
daria25D
force-pushed
the
dev/daria25D/horizontal-scroll
branch
from
ef9c639
to
e93ff6e
Compare
aldonin
previously approved these changes
Dec 13, 2021
Ten Elephants/Ten Elephants/Controllers/TrendPageController.swift
Outdated
Show resolved
Hide resolved
daria25D
force-pushed
the
dev/daria25D/horizontal-scroll
branch
from
e93ff6e
to
6020314
Compare
|
Там бага небольшая с header'ами, они при прокрутке вертикальной секции остаются на месте сверху. |
kiberkotleta92
previously approved these changes
Dec 14, 2021
Compositional layout for trends page consists of two sections: - with horizontal scroll - with vertical scroll The horizontal one uses wide cells as collection view cell. The vertical uses new preview cells. Add headers for sections to visually divide them. Closes #20.
daria25D
force-pushed
the
dev/daria25D/horizontal-scroll
branch
from
6020314
to
feedc45
Compare
kiberkotleta92
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compositional layout for trends page consists of two sections:
- with horizontal scroll
- with vertical scroll
The horizontal one should use wide cells as collection view cell.
Closes #13