Add loading of data from network #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daria25D
requested review from
aldonin,
kiberkotleta92,
chizberg and
bypolinafox
daria25D
force-pushed
the
dev/daria25D/data-loader-trends
branch
from
813be6c
to
c4041b9
Compare
aldonin
requested changes
Dec 14, 2021
Ten Elephants/Ten Elephants/DataProvider/MealsDataProviderNetwork.swift
Outdated
Show resolved
Hide resolved
Ten Elephants/Ten Elephants/DataProvider/MealsDataProviderNetwork.swift
Outdated
Show resolved
Hide resolved
daria25D
force-pushed
the
dev/daria25D/data-loader-trends
branch
2 times, most recently
from
382219f
to
63d5049
Compare
chizberg
previously approved these changes
Dec 15, 2021
chizberg
previously approved these changes
Dec 15, 2021
kiberkotleta92
approved these changes
Dec 15, 2021
kiberkotleta92
previously approved these changes
Dec 15, 2021
|
Там 2 коммита, может объединим? |
|
И еще конфликты появились |
daria25D
dismissed stale reviews from kiberkotleta92 and chizberg
via
dd0943d
bypolinafox
requested changes
Dec 15, 2021
Ten Elephants/Ten Elephants/DataProvider/MealsDataProviderNetwork.swift
Outdated
Show resolved
Hide resolved
Ten Elephants/Ten Elephants/DataProvider/MealsDataProviderNetwork.swift
Outdated
Show resolved
Hide resolved
daria25D
force-pushed
the
dev/daria25D/data-loader-trends
branch
2 times, most recently
from
bb45612
to
7cd1db5
Compare
Merged
aldonin
previously approved these changes
Dec 15, 2021
daria25D
force-pushed
the
dev/daria25D/data-loader-trends
branch
from
7cd1db5
to
0562296
Compare
aldonin
approved these changes
Dec 15, 2021
bypolinafox
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of stub data load data from network.
While data is not loaded, show loading indicator for vertical section and label animation for horizontal section. Close #37 , close #40 .