-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gix_mailmap::Snapshot
does not implement Debug
or Eq
#1424
Comments
Thanks for letting me know! Is this something you'd like to submit a PR for? If not (or it's more complicated), I am happy to pitch in. |
I can try to find the time to take a look once I’ve popped enough other tasks off the stack. But maybe just |
Alright, a PR is up, and the debug print should be fine (it's just a Vec internally). |
And the fix is available here: https://github.com/Byron/gitoxide/releases/tag/gix-mailmap-v0.23.3 |
Summary 💡
It would be nice to be able to print and compare
.mailmap
snapshots for equality. Ideally the semantics would be the same as with.entries()
, but without allocating a newVec
.Motivation 🔦
I would like to include this type in types that
#[derive(Debug, PartialEq, Eq)]
for martinvonz/jj#3951, and it just seems like generally‐useful functionality to have.The text was updated successfully, but these errors were encountered: