Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests into releases #42

Closed
Nikoli opened this issue Jan 16, 2014 · 5 comments
Closed

Include tests into releases #42

Nikoli opened this issue Jan 16, 2014 · 5 comments

Comments

@Nikoli
Copy link
Contributor

Nikoli commented Jan 16, 2014

Please include tests into releases, Gentoo python packages run them before installing.

@byroot
Copy link
Owner

byroot commented Jan 16, 2014

I tried, but all I was able to do is to not include them.

I would accept a PR though.

@sbraz
Copy link

sbraz commented Jan 31, 2016

Hi, I just tried running python setup.py sdist and the tests are included in the resulting tarball.
Could it be that you use a MANIFEST.in that is not present in the git repo?

@byroot
Copy link
Owner

byroot commented Jan 31, 2016

I don't have any MANIFEST.in.

$ python setup.py sdist
running sdist
running egg_info
writing requirements to pysrt.egg-info/requires.txt
writing pysrt.egg-info/PKG-INFO
writing top-level names to pysrt.egg-info/top_level.txt
writing dependency_links to pysrt.egg-info/dependency_links.txt
writing entry points to pysrt.egg-info/entry_points.txt
reading manifest file 'pysrt.egg-info/SOURCES.txt'
writing manifest file 'pysrt.egg-info/SOURCES.txt'
running check
creating pysrt-1.0.1
creating pysrt-1.0.1/pysrt
creating pysrt-1.0.1/pysrt.egg-info
making hard links in pysrt-1.0.1...
hard linking README.rst -> pysrt-1.0.1
hard linking setup.py -> pysrt-1.0.1
hard linking pysrt/__init__.py -> pysrt-1.0.1/pysrt
hard linking pysrt/commands.py -> pysrt-1.0.1/pysrt
hard linking pysrt/comparablemixin.py -> pysrt-1.0.1/pysrt
hard linking pysrt/compat.py -> pysrt-1.0.1/pysrt
hard linking pysrt/srtexc.py -> pysrt-1.0.1/pysrt
hard linking pysrt/srtfile.py -> pysrt-1.0.1/pysrt
hard linking pysrt/srtitem.py -> pysrt-1.0.1/pysrt
hard linking pysrt/srttime.py -> pysrt-1.0.1/pysrt
hard linking pysrt/version.py -> pysrt-1.0.1/pysrt
hard linking pysrt.egg-info/PKG-INFO -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/SOURCES.txt -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/dependency_links.txt -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/entry_points.txt -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/requires.txt -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/top_level.txt -> pysrt-1.0.1/pysrt.egg-info
Writing pysrt-1.0.1/setup.cfg
Creating tar archive

Honestly I don't do much python these days, so I'm not very familiar with the packaging solutions.

@EdwardBetts
Copy link
Contributor

Pull request: #59

@byroot
Copy link
Owner

byroot commented Apr 23, 2016

I released a 1.1.1 that includes the test. Thanks everybody.

@byroot byroot closed this as completed Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants