Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding binaries to the release artifacts #159

Closed
morenol opened this issue Oct 24, 2023 · 3 comments · Fixed by #161
Closed

Consider adding binaries to the release artifacts #159

morenol opened this issue Oct 24, 2023 · 3 comments · Fixed by #161

Comments

@morenol
Copy link
Contributor

morenol commented Oct 24, 2023

Can we add cargo-component binaries in the release artifacts? I can work on that
@peterhuene
Copy link
Member

I don't see why not. Thanks for taking that on!

@peterhuene peterhuene linked a pull request Oct 25, 2023 that will close this issue
chore: publish binaries #161
Merged
@peterhuene
Copy link
Member

peterhuene commented Oct 25, 2023 •
edited
Loading

@morenol It looks like the Windows one failed: https://github.com/bytecodealliance/cargo-component/actions/runs/6644604756/job/18054113468#step:7:5

We probably need to explicitly specify the shell to bash.

@morenol
Copy link
Contributor Author

morenol commented Oct 25, 2023

Checking it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: publish binaries morenol/cargo-component
2 participants
@peterhuene @morenol