Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Serialize trap manifest and tables in lucet-module-data #20

Closed
ghost opened this issue Feb 19, 2019 · 1 comment
Closed

Serialize trap manifest and tables in lucet-module-data #20

ghost opened this issue Feb 19, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 19, 2019

Support for these is not landing in #16, but we would eventually like all of the module metadata to live in that structure.

The main challenge here will be keeping the amount of copying down, since the trap metadata is potentially quite large. To that end, we'll probably want to keep at least the tables, but potentially also the manifest as a byte slice to allow zero-copy deserialization. We'll want to be very careful with alignment when we do that.

@awortman-fastly
Copy link
Contributor

This has been moved to ModuleData, and both are deserialized in a zero-copy manner. We still need to be very careful with alignment and layout if we change FunctionSpec or trap site layout in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant