Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C API: creating a module should require an engine, not a store #2025

Closed
fitzgen opened this issue Jul 15, 2020 · 1 comment · Fixed by #2026
Closed

C API: creating a module should require an engine, not a store #2025

fitzgen opened this issue Jul 15, 2020 · 1 comment · Fixed by #2026
Labels
wasmtime Issues about wasmtime that don't fall into another label

Comments

@fitzgen
Copy link
Member

fitzgen commented Jul 15, 2020

We made changes to the Rust API so that creating a module requires an engine, not a store. However, we didn't propagate this change out to the C API (nor the python API and I assume not to the go or .NET APIs either).

We should do this. It might require using non-standard wasmtime.h functions, unless we convince upstream to make this change as well.

@fitzgen fitzgen added the wasmtime Issues about wasmtime that don't fall into another label label Jul 15, 2020
@yurydelendik
Copy link
Collaborator

yurydelendik commented Jul 15, 2020

We made changes to the Rust API so that creating a module requires an engine, not a store.

Yeah, the reason was HostRef. Now since it is gone we can change signature of wasmtime_module_new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime Issues about wasmtime that don't fall into another label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants