Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime doesn't support fibers on platform s390x #2825

Closed
e-desouza opened this issue Apr 12, 2021 · 3 comments
Closed

wasmtime doesn't support fibers on platform s390x #2825

e-desouza opened this issue Apr 12, 2021 · 3 comments

Comments

@e-desouza
Copy link

I noticed lack of s390x support from the docs and as expected, it does fail on RHEL 8 on s390x.

thread 'main' panicked at 'wasmtime doesn't support fibers on platform: s390x-nknown-linux-gnu', /home/linux1/.cargo/registry/src/github.com-eae4ba8cbf2ce1c7/wasmtime-fiber-0.24.0/build.rs:17:9

I can provide s390x machines so what is the best way integrate into the CI/CD pipeline? Implementing the JIT will be non-trivial but we could start with just plain old interpreted mode (if one exists).

@cfallin
Copy link
Member

cfallin commented Apr 12, 2021

Greetings, @e-desouza!

Indeed, as you note, fibers support is a somewhat minor issue on a new CPU architecture compared to the main hurdle: adding JIT-compiler support. (Wasmtime doesn't yet have an interpreter mode but it may in the future.)

Regarding the Cranelift-based JIT: @uweigand has actually been working on s390x support for a while now; my understanding is that there is a backend that works but it is still in progress and has not yet been made public / merged. CI is an issue: @uweigand also offered access to s390x machines via IBM but GitHub's CI runner (used to run CI on one's own machines) is a .NET program, apparently, and .NET itself has not been ported to s390x. In principle we could merge something without CI and support it on a "it will keep compiling" best-effort basis, though.

Anyway -- @uweigand, do you have any recent updates on this?

@uweigand
Copy link
Member

Hi @e-desouza, I'd be interested to understand your use case for wasmtime on Z (feel free to contact me offline).

Indeed I do have a working s390x back-end (which is currently broken due to the unwinder rewrite -- @cfallin, I'll follow up on that with you separately). While I've been a bit sidetracked with other projects recently, I hope we can get this merged in the medium term to at least benefit from ongoing compile testing. Ideally, we'd also get the GitHub CI runner going (actually, porting .NET is one of those projects I've been spending my time on recently :-)), but that'll still take some time.

@uweigand
Copy link
Member

Initial support for s390x has just been merged into mainline: #2874, so I think this issue can be closed now. Let me know if you run into any problems with the port.

@bnjbvr bnjbvr closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants