Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: Forbid argument extensions for floats and SIMD vectors #5536

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

afonso360
Copy link
Contributor

馃憢 Hey,

This fixes #5531 by adding a verifier check and changing fuzzgen to not produce this type of code.

The check forbids argument extensions for anything that is not a scalar integer.

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Jan 5, 2023
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@fitzgen fitzgen merged commit 9556cb1 into bytecodealliance:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cranelift: Compile failure with argument extensions on floating point values on riscv64
2 participants