Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

atomic.fence is missing memory order immediate #59

Closed
eqrion opened this issue Feb 26, 2020 · 2 comments
Closed

atomic.fence is missing memory order immediate #59

eqrion opened this issue Feb 26, 2020 · 2 comments

Comments

@eqrion
Copy link
Contributor

eqrion commented Feb 26, 2020

See binary format in [1]. There's a reserved single byte for a memory order argument for atomic.fence. It's not specifiable in the text format.

[1] https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md

@alexcrichton
Copy link
Member

Oh dear, this is what happens when 99% of your tests are against another tool (in this case wabt) and then this implements more features than that tool! Thanks for the report though!

@eqrion
Copy link
Contributor Author

eqrion commented Feb 26, 2020

Thanks for the quick fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants