You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently spk_ttyio.c file contains speakup ldisc code and other other functionality. We should split this file into two: one to contain ldisc specific code and the other to contain rest.
The text was updated successfully, but these errors were encountered:
It seems like N_SPEAKUP is quite specific to speakup system so it is unlikely to be used elsewhere. There is also a closer coupling between speakup ldisc and spk_ttyio: check how spk_ttyio.c:ttyio_in() and spk_ttyio.c:spk_ttyio_receive_buf2() coordinate to receive input.
Therefore refactoring speakup ldisc into its own module would increase complexity while at the same time not provide benefits as we don't expect other systems to use N_SPEAKUP. Not fixing this for now, unless there is stronger reason to do so.
Currently spk_ttyio.c file contains speakup ldisc code and other other functionality. We should split this file into two: one to contain ldisc specific code and the other to contain rest.
The text was updated successfully, but these errors were encountered: