Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out speakup ldisc code into its own module #4

Closed
bytefire opened this issue Aug 28, 2017 · 3 comments
Closed

Separate out speakup ldisc code into its own module #4

bytefire opened this issue Aug 28, 2017 · 3 comments

Comments

@bytefire
Copy link
Owner

Currently spk_ttyio.c file contains speakup ldisc code and other other functionality. We should split this file into two: one to contain ldisc specific code and the other to contain rest.

@bytefire
Copy link
Owner Author

It seems like N_SPEAKUP is quite specific to speakup system so it is unlikely to be used elsewhere. There is also a closer coupling between speakup ldisc and spk_ttyio: check how spk_ttyio.c:ttyio_in() and spk_ttyio.c:spk_ttyio_receive_buf2() coordinate to receive input.

Therefore refactoring speakup ldisc into its own module would increase complexity while at the same time not provide benefits as we don't expect other systems to use N_SPEAKUP. Not fixing this for now, unless there is stronger reason to do so.

@sthibaul
Copy link

I was indeed quite wondering about any benefits we might have with it :)

@bytefire
Copy link
Owner Author

Actually this is was suggested by Alan Cox during a review. But our use of ldisc is different/creative :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants