Fix potential _channel UnboundLocalError
#15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to disable certain algorithms
If there's an exception thrown as we're calling `SFTPClient.from_transport()`, then `_channel` won't ever get created in the lexical environment and this causes a `UnboundLocalError` on top of the exception that's getting passed along, creating unnecessary noise. Fix this by always defining the variable, and then making sure it is non-`None` before trying to close it.
byteskeptical
approved these changes
Sep 24, 2022
Merged
|
I'm merging these changes with PR #13 for a few different reasons. Hoping to keep all commits into root signed at least for now. I also wanted to update changes in the docs directory but couldn't push bach to your branch. Kudos for moving to GitLab and for providing a fix for this regression. |
byteskeptical
added a commit
that referenced
this pull request
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when assigning to
_channel, an exception can occur inSFTPClient.from_transport(). Because_channeldoesn't exist if that happens, it causes a second exception when trying to callclose()in thefinallyblock. Assign to the variable outside thetryblock initially so that this exception can't happen in the future. Also make sure that_channelis notNonebefore we try to close it to account for it being sometimesNone.