Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing resolution on Linux fails silently #7

Closed
wingated opened this issue Jan 9, 2018 · 3 comments
Closed

Changing resolution on Linux fails silently #7

wingated opened this issue Jan 9, 2018 · 3 comments
Assignees
Labels

Comments

@wingated
Copy link

wingated commented Jan 9, 2018

Changing:

UrbanCity UAVAgent uav0 512 512 PrimaryPlayerCamera OrientationSensor LocationSensor VelocitySensor IMUSensor

to

UrbanCity UAVAgent uav0 480 640 PrimaryPlayerCamera OrientationSensor LocationSensor VelocitySensor IMUSensor

results in a silent hang - looks like the holodeck subprocess has died.

@joshgreaves joshgreaves self-assigned this Jan 9, 2018
@joshgreaves joshgreaves added the bug label Jan 9, 2018
@joshgreaves
Copy link
Contributor

I recreated the bug with logging and found these lines:
[2018.01.10-01.08.25:449][ 0]LogTemp: Warning: Getting buffer of size 1048576
[2018.01.10-01.08.25:449][ 0]LogHolodeck: Subscribing sensor PrimaryPlayerCamera for uav0

It seems 1048576 should be height * width * sizeof(FColor).
FColor is 32 bits so that size is wrong: 480 * 640 * 32 = 9830400 so the allocated buffer is far too small.

Also, we need to have functionality to change the buffer size in Python. @mitchneutron and I discussed changing enums to individual sensor classes with member functions, instead of dictionaries from enum to value.

Handing over to @mitchneutron since the PrimaryPlayerCamera buffer is something he worked on before.

@mitchneutron
Copy link
Contributor

The crash due to the viewport size being different than expected should now be fixed. The fix is in the viewportBug branch of Holodeck. I'm still trying to narrow down the allocated buffer size bug.

@mitchneutron
Copy link
Contributor

The crash is now fixed with Nick's merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants